Move VM options to jvm.config #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalya
approved these changes
Aug 25, 2023
.mvn/jvm.config
Outdated
| @@ -0,0 +1 @@ | |||
| --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED | |||
There was a problem hiding this comment.
if you could get rid of that eye sore end of line.
andythsu
approved these changes
Aug 25, 2023
willmostly
force-pushed
the
will/support_unwrapped_mvn
branch
from
391dd12
to
151a45f
Compare
mosabua
requested changes
Aug 28, 2023
| @@ -281,8 +281,7 @@ if [ -n "$wrapperSha256Sum" ]; then | |||
| fi | |||
|
|
|||
| #This option is required by the javalite db-migrator-maven-plugin, which does not support adding VM options in its config | |||
| REQUIRED_BUILD_OPTIONS='--add-opens=java.base/java.net=ALL-UNNAMED' | |||
| MAVEN_OPTS="$(concat_lines "$MAVEN_PROJECTBASEDIR/.mvn/jvm.config") $REQUIRED_BUILD_OPTIONS $MAVEN_OPTS" | |||
| MAVEN_OPTS="$(concat_lines "$MAVEN_PROJECTBASEDIR/.mvn/jvm.config") $MAVEN_OPTS" | |||
There was a problem hiding this comment.
do NOT modify the generated mvnw wrapper script .. this will be wiped whenever we upgrade the wrapper
There was a problem hiding this comment.
this changes it back to the generated version
There was a problem hiding this comment.
except for the comment - let me regenerate the wrapper
willmostly
force-pushed
the
will/support_unwrapped_mvn
branch
from
151a45f
to
77440d9
Compare
willmostly
force-pushed
the
will/support_unwrapped_mvn
branch
from
77440d9
to
2fb5e28
Compare
|
This fails to build locally for me .. you want output @willmostly ? |
|
Is this ready now @willmostly ? I don't think you pushed the regenerated wrapper.. |
mosabua
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the build to succeed using
mvn installinstead of requiring./mvnw install