Remove non-null restriction for QueryHistory #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
approved these changes
Jun 6, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/persistence/dao/QueryHistory.java
Show resolved
Hide resolved
oneonestar
force-pushed
the
star/fix_history_record
branch
from
884eb89
to
729af62
Compare
oneonestar
force-pushed
the
star/fix_history_record
branch
from
729af62
to
a2a720e
Compare
|
I added a release notes entry for this since I think it is kinda user facing.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
userNameandsourcein QueryHistory are nullable.userName(ie.X-Trino-User) is optional in request. If not supplied, the session user is automatically determined via user mapping by coordinator. Trino-gateway won't be able to know the user determined by user mapping.sourceis optional in Trino:https://github.com/trinodb/trino/blob/edd5d5bec766e90053e7c28ff9c9dc254790fdb0/core/trino-spi/src/main/java/io/trino/spi/eventlistener/QueryContext.java#L45
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.