Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacement pass on clearly exception NotImplementedError #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replacement pass on clearly exception NotImplementedError #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions trino/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
class Authentication(metaclass=abc.ABCMeta):
@abc.abstractmethod
def set_http_session(self, http_session: Session) -> Session:
pass
raise NotImplementedError

def get_exceptions(self) -> Tuple[Any, ...]:
return tuple()
Expand Down Expand Up @@ -209,11 +209,11 @@ class _OAuth2TokenCache(metaclass=abc.ABCMeta):

@abc.abstractmethod
def get_token_from_cache(self, host: Optional[str]) -> Optional[str]:
pass
raise NotImplementedError

@abc.abstractmethod
def store_token_to_cache(self, host: Optional[str], token: str) -> None:
pass
raise NotImplementedError


class _OAuth2TokenInMemoryCache(_OAuth2TokenCache):
Expand Down
8 changes: 4 additions & 4 deletions trino/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ def decorated(*args, **kwargs):
class ValueMapper(abc.ABC, Generic[T]):
@abc.abstractmethod
def map(self, value: Any) -> Optional[T]:
pass
raise NotImplementedError


class NoOpValueMapper(ValueMapper[Any]):
Expand Down Expand Up @@ -900,11 +900,11 @@ def __init__(self, whole_python_temporal_value: PythonTemporalType, remaining_fr

@abc.abstractmethod
def new_instance(self, value: PythonTemporalType, fraction: Decimal) -> TemporalType[PythonTemporalType]:
pass
raise NotImplementedError

@abc.abstractmethod
def to_python_type(self) -> PythonTemporalType:
pass
raise NotImplementedError

def round_to(self, precision: int) -> TemporalType:
"""
Expand All @@ -930,7 +930,7 @@ def add_time_delta(self, time_delta: timedelta) -> PythonTemporalType:
"""
This method shall be overriden to implement fraction arithmetics.
"""
pass
raise NotImplementedError

def normalize(self, value: PythonTemporalType) -> PythonTemporalType:
"""
Expand Down