Disallow querying delta lake properties table #10447
Conversation
findinpath
force-pushed
the
disallow-querying-delta-lake-properties-table
branch
from
527b7e4
to
abab02c
Compare
| @@ -60,6 +63,9 @@ | |||
| if (table.isEmpty()) { | |||
| throw new TableNotFoundException(tableName); | |||
| } | |||
| if (isDeltaLakeTable(table.get())) { | |||
| throw new TrinoException(HIVE_UNSUPPORTED_FORMAT, "Cannot query Delta Lake table"); | |||
There was a problem hiding this comment.
nit: would be good to mention table name in error message
There was a problem hiding this comment.
I modified the exception message to its original format to be in sync with the other places where the exception is being thrown.
There was a problem hiding this comment.
I agree with @phd3 we should provide table name in the message.
There was a problem hiding this comment.
Good point. I'll make a separate commit then to update everywhere the exception message.
There was a problem hiding this comment.
agreed, the io.trino.plugin.hive.HiveMetadata#getTableHandle can (and should) be updated in a separate commit.
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
disallow-querying-delta-lake-properties-table
branch
2 times, most recently
from
f93877c
to
0b757ba
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/PropertiesSystemTableProvider.java
Show resolved
Hide resolved
findinpath
force-pushed
the
disallow-querying-delta-lake-properties-table
branch
2 times, most recently
from
349c5a0
to
55da414
Compare
| @@ -60,6 +63,9 @@ | |||
| if (table.isEmpty()) { | |||
| throw new TableNotFoundException(tableName); | |||
| } | |||
| if (isDeltaLakeTable(table.get())) { | |||
| throw new TrinoException(HIVE_UNSUPPORTED_FORMAT, "Cannot query Delta Lake table"); | |||
There was a problem hiding this comment.
I agree with @phd3 we should provide table name in the message.
findinpath
force-pushed
the
disallow-querying-delta-lake-properties-table
branch
from
55da414
to
9c252f8
Compare
findinpath
force-pushed
the
disallow-querying-delta-lake-properties-table
branch
from
9c252f8
to
acb1779
Compare
|
Merged, thanks! |
Extracted relevant commits for disallowing the querying of the
$propertiestable on the delta lake tables in hive from the PR #10441