Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate DataTypeTest to SqlDataTypeTest in MySQL #10456

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Migrate DataTypeTest to SqlDataTypeTest in MySQL #10456

merged 4 commits into from
Jan 5, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 4, 2022

Fixes #6392

@cla-bot cla-bot bot added the cla-signed label Jan 4, 2022
hashhar
hashhar approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the migration and adding more test cases.

@ebyhr ebyhr merged commit 6e08a14 into trinodb:master Jan 5, 2022
@ebyhr ebyhr deleted the ebi/mysql-sql-tests branch January 5, 2022 10:27
@github-actions github-actions bot added this to the 368 milestone Jan 5, 2022
@mosabua mosabua mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
368
Development

Successfully merging this pull request may close these issues.

Convert TestMySqlTypeMapping to use SqlDataTypeTest
2 participants
@ebyhr @hashhar