Avoid reflection and services lookup for JWT processing #10954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick turnaround on the patch, @electrum! It'd be much appreciated if @akashkatipally gets credit somewhere for finding the regression. |
|
Fixes #10889 @electrum See also other service loader uses in #10889 (comment) |
dain
approved these changes
Feb 4, 2022
kokosing
approved these changes
Feb 5, 2022
|
|
||
| import java.util.Map; | ||
|
|
||
| // avoid reflection and services lookup |
There was a problem hiding this comment.
I think it would be nice to report the issue to jwt library. I am not sure why they used that in the first place.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression due to 37c7d22.
Fixes #10889
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: