Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide and test trino-server-377 #187

Closed
7 tasks done
maltesander opened this issue Apr 12, 2022 · 1 comment
Closed
7 tasks done

Provide and test trino-server-377 #187

maltesander opened this issue Apr 12, 2022 · 1 comment
Assignees

Comments

@maltesander
Copy link
Member

maltesander commented Apr 12, 2022

We are currently on Trino version 362. We should update to the newest version before making a release. This includes:

  • Uploading the trino-server-377.tar.gz into the repository
  • Release new version of trino-opa-authorizer compatible with version 377
  • Create new docker image with version 377
  • Adapt (if required) and test the operator and the product
  • Create integration tests for version 377
  • Update documentation to include supported version(s)
  • Update examples to use new versions

There are too many changes/fixes to list them all, so here is a small list of changes that may directly affect us (Security, Hive, JDBC etc.):

  • 364

    • JDBC: Allow using token from existing Kerberos context. This allows the client to perform Kerberos authentication without passing the Keytab or credential cache to the driver. (#4826)
    • WEB UI: Improve responsiveness of Web UI when query history contains queries with long query text. (#8892)
  • 365

    • Security: Use internal names for discovery client when automatic TLS is enabled for internal communications. This allows discovery.uri to be configured using a normal DNS name like https://coordinator.trino and still use automatic TLS certificates. (#9821)
    • Security: Use Kerberos operating system ticket cache if keytab file is not provided to JDBC and CLI for Kerberos authentication. (#8987)
    • Hive Connector: Enable hive.s3.streaming by default. (#9715)
  • 366

    • Hive Connector: Improve performance of uploading data into tables that use S3 filesystem. (#10180)
  • 367

    • Security: Hide inaccessible columns from SELECT * statement when the hide-inaccessible-columns configuration property is set to true. (#9991)
    • Hive Connector: Prevent data loss during DROP SCHEMA when schema location contains files but not tables. (#10146)
    • Hive Connector: Ensure no duplicate rows are created if query which writes data to Hive table is retried. (#10252, #10064)
  • 368

    • General: Allow setting per task memory limits via query.max-total-memory-per-task config property or via query_max_total_memory_per_task session property. (#10308)
    • Hive Connector: Reduce risk of worker out-of-memory exception when scanning ORC files. (#9949)
  • 369

    • General: Remove distinction between system and user memory to simplify cluster configuration. The configuration property query.max-total-memory-per-node is removed. Use query.max-memory-per-node instead. (#10574)
    • Hive Connector: Prevent data loss during DROP SCHEMA when the schema location contains files that are not part of existing tables. (#10485)
    • Hive Connector: Fix possible data corruption when writing data to S3 with streaming enabled. (#10710)
  • 370

    • General: Fix query scheduling regression introduced in Trino 360 that caused coordinator slowness in assigning splits to workers. (#10839)
  • 371

    • General: Fix performance regression in internal communication authentication processing. (#10954)
    • Security: Invoke correct authorization check when table is created via CREATE TABLE AS. (#10939)
  • 372

    • Security: Allow configuration of connect and read timeouts for LDAP authentication. (#10925)
    • Hive Connector: Fix potential query failures for queries writing data to tables backed by S3. (#11089)
  • 373

    • WebUI: Add CPU time, scheduled time, and cumulative memory statistics regarding failed tasks in a query. (#10754)
    • Hive Connector: Fix issue where duplicate rows could be inserted into a partition when insert_existing_partitions_behavior was set to OVERWRITE and retry-policy was TASK. (#11196)
  • 376

    • Security: Add support to use two-way TLS/SSL certificate validation with LDAP authentication. (#11070)
    • WebUI: Add new page to display the runtime information of all workers in the cluster. (#11653)
    • Hive Connector: Improve performance when reading Parquet data. (#11675)
@maltesander maltesander self-assigned this Apr 12, 2022
@maltesander
Copy link
Member Author

First test with 376 throws the error:

trino 2022-04-12T15:47:21.659Z    ERROR    main    io.trino.server.Server    Configuration is invalid                    
trino Errors:                                                                                                            
trino                                                                                                                    
trino 1) Defunct property 'query.max-total-memory-per-node' (class [class io.trino.memory.NodeMemoryConfig]) cannot be co
nfigured.                                                                                                                
trino 2) Configuration property 'query.max-total-memory-per-node' was not used                                           

which makes sense because of Remove distinction between system and user memory to simplify cluster configuration. The configuration property query.max-total-memory-per-node is removed. Use query.max-memory-per-node instead. (trinodb/trino#10574)

We will have to treat the two versions differently here. A problem is that we have the property set in the custom resource. So doing it only in the product config is not enough. We need some sort of differentiation in code.

@maltesander maltesander changed the title Provide and test trino-server-376 Provide and test trino-server-377 Apr 19, 2022
bors bot pushed a commit that referenced this issue Apr 26, 2022
## Description

- supporting version 377
- updated to operator-rs 0.17
- updated to config changes in version 377
- updated examples and regorules

Integration test PR: https://github.com/stackabletech/integration-tests/pull/225

closes #187



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Felix Hennig <felix.hennig@stackable.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant