Refactor TestingMySqlServer constructor to take version numbers #11105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows version-based testing of mysql
ebyhr
requested changes
Feb 19, 2022
| } | ||
|
|
||
| public TestingMySqlServer(String dockerImageName, boolean globalTransactionEnable) | ||
| public TestingMySqlServer(int majorVersion, int minorVersion, int patchVersion, boolean globalTransactionEnable) |
There was a problem hiding this comment.
If the refactoring purpose is
Allows version-based testing of mysql. For example, testing specific features from mysql8 that are not supported in mysql5.
the original code should be sufficient.
hashhar
reviewed
Feb 21, 2022
Comment on lines
+36
to
+38
| public final int majorVersion; | ||
| public final int minorVersion; | ||
| public final int patchVersion; |
There was a problem hiding this comment.
What about adding public static constants for the versions to test - LATEST_IMAGE, DEFAULT_IMAGE?
That should be sufficient?
|
Closing due to this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows version-based testing of mysql. For example, testing specific features from mysql8 that are not supported in mysql5.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: