Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL connector test for version 5.7 #11106

Merged
merged 2 commits into from Feb 22, 2022
Merged

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Feb 19, 2022

Description

Add MySQL connector test for version 5.7

Related issues, pull requests, and links

n/a

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Feb 19, 2022
@ebyhr ebyhr requested a review from hashhar February 21, 2022 23:47
Comment on lines +33 to +34
public static final String DEFAULT_IMAGE = "mysql:8.0.12";
public static final String LEGACY_IMAGE = "mysql:5.7.35";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @grantatspothero

This should make #11105 not needed anymore.

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebyhr ebyhr merged commit 4aa5190 into trinodb:master Feb 22, 2022
@ebyhr ebyhr deleted the ebi/mysql-5.7 branch February 22, 2022 07:22
@github-actions github-actions bot added this to the 372 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants