Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document CLI configuration file #12815

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Document CLI configuration file #12815

merged 1 commit into from
Aug 10, 2022

Conversation

nineinchnick
Copy link
Member

Description

Document how to use the CLI's configuration file.

Is this change a fix, improvement, new feature, refactoring, or other?
doc

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
cli

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Extracted from #12208

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 13, 2022
@nineinchnick nineinchnick marked this pull request as ready for review June 13, 2022 07:59
@nineinchnick nineinchnick mentioned this pull request Jun 13, 2022
Merged
@github-actions github-actions bot added the docs label Jun 13, 2022
@nineinchnick nineinchnick added the no-release-notes This pull request does not require release notes entry label Jul 18, 2022
@nineinchnick
Copy link
Member Author

@wendigo @hashhar PTAL

@nineinchnick nineinchnick force-pushed the doc-cli-config branch 2 times, most recently from 4bea07e to c1a13f3 Compare July 27, 2022 10:21
hashhar
hashhar approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me % @mosabua's comments if any.

@nineinchnick
Copy link
Member Author

@hashhar @mosabua PTAL, I think this one is ready to go

@raunaqmorarka raunaqmorarka merged commit 44ab99d into trinodb:master Aug 10, 2022
@github-actions github-actions bot added this to the 393 milestone Aug 10, 2022
@colebow colebow mentioned this pull request Aug 10, 2022
Merged
@nineinchnick nineinchnick deleted the doc-cli-config branch November 2, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@aakashnand aakashnand aakashnand left review comments

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@mosabua mosabua Awaiting requested review from mosabua

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry
Milestone
393
Development

Successfully merging this pull request may close these issues.
4 participants
@nineinchnick @raunaqmorarka @hashhar @aakashnand