Describe per-connector support for fault-tolerant execution #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
reviewed
Jun 14, 2022
| is only supported by the :doc:`/connector/delta-lake`, | ||
| :doc:`/connector/hive`, and :doc:`/connector/iceberg`. | ||
|
|
||
| Note that setting ``retry-policy`` effectively disables :ref:`write operations |
There was a problem hiding this comment.
This should be a warning imho and remove the "Note that" and maybe also do not quote the error message specifically
There was a problem hiding this comment.
Switched to warning and reworded a bit to emphasize the "warning" part of this note.
I think the error message text is important to put here, because when troubleshooting people are going to search for that text. The text also does not mention fault-tolerant execution making it harder to trace the cause back here.
We'll just have to update the text when it changes, business as usual.
mosabua
requested changes
Jun 14, 2022
hashhar
reviewed
Jun 14, 2022
jhlodin
force-pushed
the
jl/fte-connector-support
branch
from
cad42e0
to
198254b
Compare
jhlodin
force-pushed
the
jl/fte-connector-support
branch
from
198254b
to
415dd15
Compare
jhlodin
changed the title
mosabua
approved these changes
Jun 15, 2022
brianzhan
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add newly-uncovered information about per-connector support for fault-tolerant execution.
Improvement
Documentation
Adds information necessary to understand how fault-tolerant execution behaves with different connectors
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: