Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most product tests for CDH 5 #13630

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

electrum
Copy link
Member

The only remaining tests are for Hadoop KMS, which require #1652.

Description

Is this change a fix, improvement, new feature, refactoring, or other?

refactoring

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The only remaining tests are for Hadoop KMS.
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM
However, in #13628 it seems too much was removed (compared with the PR title)

We should be able to remove the "default" config (old HDP) and make HDP3 the new default. This should be a follow-up

@electrum electrum merged commit 1ed0189 into trinodb:master Aug 12, 2022
@electrum electrum deleted the cdh5-pt branch August 12, 2022 08:11
@github-actions github-actions bot added this to the 393 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants