Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow adding not null columns in Iceberg #13673

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Disallow adding not null columns in Iceberg #13673

merged 2 commits into from
Aug 17, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Aug 15, 2022 •
edited
Loading

Description

  • Disallow adding not null columns in Iceberg and Delta Lake
  • Add test for adding not null column in BaseConnectorTest

Relates to #13587

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# Iceberg
* Disallow specifying `NOT NULL` constraint when adding a new column. Previously, the option was ignored. ({issue}`13673`)

@cla-bot cla-bot bot added the cla-signed label Aug 15, 2022
@ebyhr ebyhr force-pushed the ebi/test-not-null-71e11c35cb branch from 13cfa07 to baaf15a Compare August 15, 2022 05:54
@ebyhr ebyhr marked this pull request as draft August 15, 2022 10:15
@ebyhr ebyhr force-pushed the ebi/test-not-null-71e11c35cb branch from baaf15a to bf95c6e Compare August 16, 2022 05:48
@ebyhr ebyhr changed the title Disallow adding not null columns in Iceberg and Delta Lake Disallow adding not null columns in Iceberg Aug 16, 2022
@ebyhr ebyhr marked this pull request as ready for review August 16, 2022 05:50
@ebyhr ebyhr requested review from hashhar and findepi August 16, 2022 05:51
@hashhar
Copy link
Member

hashhar commented Aug 16, 2022

Changes look good. PTAL at any CI failures.

@ebyhr ebyhr force-pushed the ebi/test-not-null-71e11c35cb branch from bf95c6e to 1e19ae0 Compare August 16, 2022 06:43
@findinpath findinpath self-requested a review August 16, 2022 08:39
@ebyhr ebyhr merged commit 4c6cec5 into trinodb:master Aug 17, 2022
@ebyhr ebyhr deleted the ebi/test-not-null-71e11c35cb branch August 17, 2022 00:37
@ebyhr ebyhr mentioned this pull request Aug 17, 2022
Closed
@github-actions github-actions bot added this to the 393 milestone Aug 17, 2022
@colebow colebow mentioned this pull request Aug 17, 2022
Merged
@gupteaj gupteaj mentioned this pull request Aug 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@findepi findepi Awaiting requested review from findepi

@findinpath findinpath Awaiting requested review from findinpath

Assignees
No one assigned
Labels
cla-signed
Milestone
393
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @hashhar