Improve concurrency control in TestSystemConnector #14171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race in `testQueryDuringAnalysisIsCaptured`. The test waits until query is FINISHED, but the thread calling `getQueryRunner().execute` may not have finished yet, so the Future is not done. Also, improve concurrency in `testQueryKillingDuringAnalysis`. Sleeps are not necessary to wait until query is started.
findepi
added
test
no-release-notes
kokosing
approved these changes
Sep 19, 2022
|
Thank you |
findepi
deleted the
findepi/improve-concurrency-control-in-testsystemconnector-0978b5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race in
testQueryDuringAnalysisIsCaptured. The test waits until query is FINISHED, but the thread callinggetQueryRunner().executemay not have finished yet, so the Future is not done.Also, improve concurrency in
testQueryKillingDuringAnalysis. Sleeps are not necessary to wait until query is started.Hopefully fixes #14170