Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code cleanup #14173

Merged
merged 8 commits into from Sep 19, 2022
Merged

Minor code cleanup #14173

merged 8 commits into from Sep 19, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Sep 17, 2022

No description provided.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Sep 17, 2022
@cla-bot cla-bot bot added the cla-signed label Sep 17, 2022
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver tests:hive labels Sep 17, 2022
@findepi findepi mentioned this pull request Sep 17, 2022
Closed
@findepi
Copy link
Member Author

findepi commented Sep 17, 2022

CI #13288

@findepi
Prune old SPI revapi exclusion
0c0d1fa 
This does not apply to the current release.
@findepi
Remove unused VarcharType.getParametrizedVarcharSignature method
4deba12 
This was just a helper method with last usage removed in
f1dc59f.
@findepi
Remove unused parameters in block assertions
492e61b
@findepi
Remove unused assertFunctionThrowsIncorrectly
9a51e76 
It was needed only temporarily to test functions that throw a wrong
exception. It's no longer needed and hopefully never will be.
@findepi
Remove some unused fields, parameters and methods
db39a0b
@findepi
Remove unused database comment in file metastore
ddfcd99 
It was never set.
@findepi
Remove unused DataDefinitionTask.ExplainDataDefinition interface
efb1785 
It looks like remnant of an earlier version of
8065aa8.
hashhar
hashhar approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % someone else's eyes on " Remove some unused fields, parameters and methods ".

@findepi
Copy link
Member Author

findepi commented Sep 19, 2022

Thanks @hashhar

LGTM % someone else's eyes on " Remove some unused fields, parameters and methods ".

anything you're concerned about there?

@hashhar
Copy link
Member

hashhar commented Sep 19, 2022

Everything being removed there is indeed unused but all of them look like important things and I'm not sure if the unused is intentional (AbstractBenchmark, valueToSessionTimeZoneOffsetDiff).

@findepi
Copy link
Member Author

findepi commented Sep 19, 2022

and I'm not sure if the unused is intentional (AbstractBenchmark, valueToSessionTimeZoneOffsetDiff).

AbstractBenchmark -- thse fields are used within AbstractBenchmark execution code
and don't need to be accessed by subclasses

valueToSessionTimeZoneOffsetDiff -- left over after previous cleanup d2a0414
This is a hack method, and happy it's last usage got nuked (after we removed political zones from timetz)

@findepi findepi merged commit c92c642 into trinodb:master Sep 19, 2022
@findepi findepi deleted the findepi/ccc branch September 19, 2022 18:24
@github-actions github-actions bot added this to the 397 milestone Sep 19, 2022
@colebow colebow mentioned this pull request Sep 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk approved these changes

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed jdbc Relates to Trino JDBC driver no-release-notes This pull request does not require release notes entry
Milestone
397
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@findepi @hashhar @losipiuk