Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @Flaky annotation to Databricks product tests #14899

Merged
merged 2 commits into from Nov 7, 2022
Merged

Add @Flaky annotation to Databricks product tests #14899

merged 2 commits into from Nov 7, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 4, 2022

Description

Add @Flaky annotation to Databricks product tests
Relates to #14391

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Nov 4, 2022
@cla-bot cla-bot bot added the cla-signed label Nov 4, 2022
@findinpath
Copy link
Contributor

I've found that the following tests are missing the annotation:

  • io.trino.tests.product.deltalake.TestDeltaLakeAlterTableCompatibility#testTrinoAlterTablePreservesTableMetadata
    (probably not needed because it performs only a CREATE TABLE statement on delta )
  • io.trino.tests.product.deltalake.TestDeltaLakeAlterTableCompatibility#testTrinoAlterTablePreservesTableMetadata
    (probably not needed because it performs only a CREATE TABLE statement on delta )
  • io.trino.tests.product.deltalake.TestDeltaLakeAlterTableCompatibility#testTrinoAlterTablePreservesGeneratedColumn
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoCheckpointNullStatisticsForRowType
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksCheckpointNullStatisticsForRowType
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoWriteStatsAsJsonDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksWriteStatsAsJsonDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoWriteStatsAsStructDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksWriteStatsAsStructDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testCheckConstraintsCompatibility
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testCompression(java.lang.String)
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testWritesToTableWithCheckConstraintFails
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testMetadataOperationsRetainCheckConstraints
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testWritesToTableWithGeneratedColumnFails
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testWritesToTableWithCDFFails
  • io.trino.tests.product.deltalake.TestHiveAndDeltaLakeRedirect#testInsertIntoDeltaTableFromHiveNonDefaultSchemaRedirect
  • io.trino.tests.product.deltalake.TestHiveAndDeltaLakeRedirect#testViewReferencingHiveAndDeltaTable

@ebyhr
Copy link
Member Author

ebyhr commented Nov 4, 2022 •
edited

Not sure why IntelliJ returned wrong results. Just added the annotation to all of DELTA_LAKE_DATABRICKS regardless of the detailed tests.

@findinpath
Copy link
Contributor

You're still missing

  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoCheckpointNullStatisticsForRowType
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksCheckpointNullStatisticsForRowType

@findinpath findinpath self-requested a review November 4, 2022 10:39
@ebyhr
Copy link
Member Author

ebyhr commented Nov 4, 2022

Pushed an empty commit because there was no retrying with "Communication link failure".

@ebyhr
Copy link
Member Author

ebyhr commented Nov 7, 2022 •
edited

https://github.com/trinodb/trino/actions/runs/3407215065/jobs/5666758475 has retrying with "Communication link failure", but TestDeltaLakeDatabricksCheckpointsCompatibility.testDatabricksWriteStatsAsJsonEnabled has NPE. Going to fix the issue.

@findinpath findinpath self-requested a review November 7, 2022 05:19
@ebyhr ebyhr requested a review from findepi November 7, 2022 07:00
@ebyhr ebyhr merged commit e22fdd3 into master Nov 7, 2022
@ebyhr ebyhr deleted the ebi/delta-databricks-flaky branch November 7, 2022 13:34
@github-actions github-actions bot added this to the 403 milestone Nov 7, 2022
@findepi findepi mentioned this pull request Nov 9, 2022
Closed
@colebow colebow mentioned this pull request Nov 9, 2022
Merged
@ebyhr ebyhr mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@findinpath findinpath findinpath approved these changes

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
403
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebyhr @findinpath @findepi