Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting TLS context in MongoDB #15240

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Add support for setting TLS context in MongoDB #15240

merged 3 commits into from
Nov 30, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 29, 2022 •
edited
Loading

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# MongoDB
* Rename config properties from `mongodb.ssl.enabled` to `mongodb.tls.enabled`. ({issue}`15240`)
* Add support for setting file path and password for truststore and keystore. ({issue}`15240`)

@cla-bot cla-bot bot added the cla-signed label Nov 29, 2022
@github-actions github-actions bot added the docs label Nov 29, 2022
@ebyhr ebyhr force-pushed the ebi/mongo-tls branch 4 times, most recently from c8fc479 to a703a82 Compare November 29, 2022 23:11
@ebyhr ebyhr marked this pull request as ready for review November 29, 2022 23:12
@Praveen2112
Copy link
Member

Can we have a PT for this ?

@ebyhr
Copy link
Member Author

ebyhr commented Nov 30, 2022 •
edited
Loading

I hope we will add a product test as follow-up in #15247.

Praveen2112
Praveen2112 reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a issue which tracks the PTs ?

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Show resolved Hide resolved
@ebyhr
Copy link
Member Author

ebyhr commented Nov 30, 2022

Can we create a issue which tracks the PTs ?

Sure, #15247

@ebyhr ebyhr merged commit bf0b6ee into trinodb:master Nov 30, 2022
@ebyhr ebyhr deleted the ebi/mongo-tls branch November 30, 2022 13:23
@ebyhr ebyhr mentioned this pull request Nov 30, 2022
Closed
@github-actions github-actions bot added this to the 404 milestone Nov 30, 2022
@colebow colebow mentioned this pull request Nov 30, 2022
Merged
This was referenced Dec 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveen2112 Praveen2112 Praveen2112 approved these changes

@hashhar hashhar Awaiting requested review from hashhar

Assignees
No one assigned
Labels
cla-signed docs
Milestone
405
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @Praveen2112