Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generation of JSON path keyvalue() IDs #16482

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Fix generation of JSON path keyvalue() IDs #16482

merged 1 commit into from
Mar 11, 2023

Conversation

electrum
Copy link
Member

@electrum electrum commented Mar 10, 2023 •
edited
Loading

Description

Previously, separate IDs were generated for each member.

Note that the tests pass without this fix due to an AssertJ bug that seems to cause the assertion comparisons not to work. This is fixed by upgrading AssertJ in #16420.

Release notes

(x) Release notes are required, with the following suggested text:

# General
* Fix generation of IDs for `keyvalue()` methods in [JSON path](json-path-language).
  Previously, separate IDs were generated for each member. ({issue}`16482`)

@cla-bot cla-bot bot added the cla-signed label Mar 10, 2023
@electrum electrum added bug Something isn't working correctness labels Mar 10, 2023
@electrum electrum force-pushed the jsonpath branch 2 times, most recently from 974a796 to 1ed13b2 Compare March 10, 2023 23:58
@electrum electrum requested a review from kasiafi March 10, 2023 23:58
@electrum
Fix generation of JSON path keyvalue() IDs
0a48f93 
Previously, separate IDs were generated for each member.
@electrum electrum merged commit 9e11311 into trinodb:master Mar 11, 2023
@electrum electrum deleted the jsonpath branch March 11, 2023 04:28
@github-actions github-actions bot added this to the 411 milestone Mar 11, 2023
@colebow colebow mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dain dain dain approved these changes

@martint martint Awaiting requested review from martint

@kasiafi kasiafi Awaiting requested review from kasiafi

Assignees
No one assigned
Labels
bug Something isn't working cla-signed correctness
Milestone
411
Development

Successfully merging this pull request may close these issues.
3 participants
@electrum @dain @kasiafi