Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Nessie client #21996

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented May 16, 2024

This doesn't fix anything yet, because NessieIcebergClient.close calls HttpApiV1.close, which calls RestV1Client.close, which calls, JavaHttpClient.close, which nulls out JavaHttpClient.client, without closing it.

Found by #21913

This doesn't fix anything yet, because NessieIcebergClient.close calls
HttpApiV1.close, which calls RestV1Client.close, which calls,
JavaHttpClient.close, which nulls out JavaHttpClient.client, without
closing it.
@findepi findepi requested review from wendigo and nastra May 16, 2024 10:36
@cla-bot cla-bot bot added the cla-signed label May 16, 2024
@findepi
Copy link
Member Author

findepi commented May 16, 2024

@ajantha-bhat can you please fix JavaHttpClient.close?

@github-actions github-actions bot added the iceberg Iceberg connector label May 16, 2024
@ajantha-bhat
Copy link
Member

ajantha-bhat commented May 16, 2024

@findepi: Thanks for pointing out. I will add the below code before nullifying the client at Nessie side.

    // Close associated resources
    client.executor().ifPresent(executor -> {
      if (executor instanceof ExecutorService) {
        ((ExecutorService) executor).shutdown();
      }
    }); 

@wendigo wendigo merged commit 64b2a1e into trinodb:master May 16, 2024
43 checks passed
@github-actions github-actions bot added this to the 449 milestone May 16, 2024
@findepi findepi deleted the findepi/close-nessie-client-91c99f branch May 16, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

4 participants