Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array support using definitions in the _meta field. #2462

Closed
wants to merge 1 commit into from
Closed

Add array support using definitions in the _meta field. #2462

wants to merge 1 commit into from

Conversation

bitsondatadev
Copy link
Member

Still needs a few more tests and discussion.

Fixes: #2441

@cla-bot
Copy link

cla-bot bot commented Jan 10, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Brian Olsen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@bitsondatadev
Copy link
Member Author

Just submitted my cla agreement.

@bitsondatadev bitsondatadev changed the title Add array support using definitions in the _meta field. WIP: Add array support using definitions in the _meta field. Jan 10, 2020
@bitsondatadev
Copy link
Member Author

Not sure why but a hive test failed when all my changes were in presto-elasticsearch.
https://github.com/prestosql/presto/pull/2462/checks?check_run_id=382764712#step:5:2608

Are these typical issues with the build or should I investigate this more?

@martint
Copy link
Member

martint commented Jan 11, 2020

No, those are unrelated. There are some flaky tests we're trying to track down.

@martint
Copy link
Member

martint commented Jan 11, 2020

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 11, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Brian Olsen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jan 11, 2020

The cla-bot has been summoned, and re-checked this pull request!

@bitsondatadev
Copy link
Member Author

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Brian Olsen.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

hmm will I need to recommit after setting my email in the config?

@bitsondatadev
Copy link
Member Author

I was missing my credential information when submitting my commit. I just created an identical branch and resubmitted with the appropriate info and opened this PR. #2478

@bitsondatadev bitsondatadev deleted the elasticsearch-array-support-via-meta branch January 14, 2020 21:48
@bitsondatadev bitsondatadev changed the title WIP: Add array support using definitions in the _meta field. Add array support using definitions in the _meta field. Oct 8, 2020
@bitsondatadev bitsondatadev removed the WIP label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Array/Object support for elasticsearch connector via _meta field mapping
2 participants