Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove default_ecosystem in service options #836

Closed
tmarkovski opened this issue Jul 5, 2022 · 6 comments · Fixed by #840
Closed

Deprecate and remove default_ecosystem in service options #836

tmarkovski opened this issue Jul 5, 2022 · 6 comments · Fixed by #840
Milestone

Comments

@tmarkovski
Copy link
Member

This no longer provides any value. When the authToken is set in the configuration, changing default_ecosystem has no effect. It's only used during login, when the ecosystem field is not provided. It seems we can completely remove this from the SdkOptions and rely on defaults in the server, if this is omitted.

@geel9
Copy link
Member

geel9 commented Jul 5, 2022

@fundthmcalculus and I had a discussion about this the other day -- I'm in complete agreement.

@janpieterz
Copy link
Contributor

GA candidate? @fundthmcalculus is it feasible this sprint?

@fundthmcalculus
Copy link
Member

GA candidate? @fundthmcalculus is it feasible this sprint?

Totally. This is basically a quick proto change, everything from there on is essentially automated.

@geel9
Copy link
Member

geel9 commented Jul 5, 2022

It's a sample / SDK change as well, but not bad to do.

@janpieterz
Copy link
Contributor

Awesome, moved to in progress for this sprint then.

@fundthmcalculus
Copy link
Member

@sethjback @tmarkovski is it fair to assume that if we don't send an ecosystem on login, the server automatically signs into the default ecosystem?

@fundthmcalculus fundthmcalculus added this to the SDK 1.7.0 milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants