Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default_ecosystem #840

Merged
merged 21 commits into from Jul 5, 2022
Merged

Conversation

fundthmcalculus
Copy link
Member

Closes #836

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #840 (d9a88c4) into main (da6609d) will decrease coverage by 44.43%.
The diff coverage is 62.06%.

@@              Coverage Diff              @@
##               main     #840       +/-   ##
=============================================
- Coverage     61.55%   17.12%   -44.44%     
- Complexity        0      846      +846     
=============================================
  Files            14      273      +259     
  Lines           489    41626    +41137     
  Branches          0     4347     +4347     
=============================================
+ Hits            301     7127     +6826     
- Misses          188    33818    +33630     
- Partials          0      681      +681     
Impacted Files Coverage Δ
dart/lib/src/proto/sdk/options/v1/options.pb.dart 52.45% <ø> (ø)
dart/lib/src/trinsic_util.dart 100.00% <ø> (ø)
dotnet/Trinsic/ServiceBase.cs 94.59% <ø> (-0.15%) ⬇️
dotnet/Trinsic/TrinsicService.cs 78.57% <ø> (-1.43%) ⬇️
go/services/service_base.go 61.42% <ø> (ø)
java/src/main/java/trinsic/TrinsicUtilities.java 76.19% <ø> (ø)
.../src/main/java/trinsic/sdk/options/v1/Options.java 15.51% <ø> (ø)
...src/main/java/trinsic/services/AccountServiceKt.kt 0.00% <0.00%> (ø)
...va/src/main/java/trinsic/services/ServiceBase.java 80.76% <ø> (ø)
python/samples/account_demo.py 82.60% <0.00%> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da6609d...d9a88c4. Read the comment docs.

@fundthmcalculus fundthmcalculus merged commit 9fa4021 into main Jul 5, 2022
@fundthmcalculus fundthmcalculus deleted the sdk-836-remove-default_ecosystem branch July 5, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove default_ecosystem in service options
4 participants