Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emojis in branch names break docs preview action #928

Closed
geel9 opened this issue Aug 12, 2022 · 3 comments · Fixed by #969
Closed

Emojis in branch names break docs preview action #928

geel9 opened this issue Aug 12, 2022 · 3 comments · Fixed by #969
Assignees
@tmarkovski
Labels
bug Something isn't working

Comments

@geel9
Copy link
Member

geel9 commented Aug 12, 2022 •
edited
Loading

See #927 for example

Additionally, the URL should include the commit hash, as the branch name is not a sufficiently-unique key.
@geel9 geel9 added the bug Something isn't working label Aug 12, 2022
@geel9 geel9 self-assigned this Aug 12, 2022
@geel9 geel9 mentioned this issue Aug 12, 2022
Closed
@tmarkovski
Copy link
Member

😡😤🤬🥊

@janpieterz
Copy link
Member

Lol. Assigns ™️ 😂

@janpieterz janpieterz assigned tmarkovski and unassigned geel9 Aug 12, 2022
@janpieterz
Copy link
Member

Just joking around btw (re assignment)

@geel9 geel9 mentioned this issue Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmarkovski tmarkovski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation PR automation breaking with emojis in branch names trinsic-id/sdk
3 participants
@janpieterz @tmarkovski @geel9