Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation PR automation breaking with emojis in branch names #969

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Fix documentation PR automation breaking with emojis in branch names #969

merged 3 commits into from
Aug 17, 2022

Conversation

geel9
Copy link
Member

@geel9 geel9 commented Aug 17, 2022 •
edited

  • Changes the GitHub Action which auto-hosts a preview of the docs site to use the commit hash in the generated URL, as opposed to the branch name.
    • Ensures that branch names can have any characters, including emojis, without breaking anything
    • Subsequent pushes to a PR won't overwrite previous previews

Fixes #928

tmarkovski
tmarkovski approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@tmarkovski tmarkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hero!

@github-actions
Copy link
Contributor

Preview docs site for JC/fix-docs-pr-automation@8aeb7d4c88b5f7b8df16d5e4f5b097ebee810bd9

@geel9 geel9 merged commit bab2882 into main Aug 17, 2022
@geel9 geel9 deleted the JC/fix-docs-pr-automation branch August 17, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkovski tmarkovski tmarkovski approved these changes

@fundthmcalculus fundthmcalculus fundthmcalculus approved these changes

@michaeldboyd michaeldboyd Awaiting requested review from michaeldboyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emojis in branch names break docs preview action
3 participants
@geel9 @tmarkovski @fundthmcalculus