Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied Protos from server #1166

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Copied Protos from server #1166

merged 2 commits into from
Nov 24, 2022

Conversation

mewmba
Copy link
Contributor

@mewmba mewmba commented Nov 11, 2022

👑 copied proto files from server repo

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Base: 0.00% // Head: 79.71% // Increases project coverage by +79.71% 🎉

Coverage data is based on head (f46c391) compared to base (d835e1d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1166       +/-   ##
=========================================
+ Coverage      0   79.71%   +79.71%     
=========================================
  Files         0       47       +47     
  Lines         0     1740     +1740     
=========================================
+ Hits          0     1387     +1387     
- Misses        0      353      +353     
Impacted Files Coverage Δ
dotnet/Trinsic/AccessManagementService.cs 0.00% <ø> (ø)
dotnet/Trinsic/AccountService.cs 42.30% <ø> (ø)
dotnet/Trinsic/CredentialService.cs 44.11% <ø> (ø)
dotnet/Trinsic/ProviderService.cs 35.44% <ø> (ø)
dotnet/Trinsic/TemplateService.cs 42.85% <ø> (ø)
dotnet/Trinsic/TrustRegistryService.cs 51.35% <ø> (ø)
dotnet/Trinsic/WalletService.cs 36.36% <ø> (ø)
ruby/lib/services/account_service.rb 50.00% <ø> (ø)
ruby/lib/services/credential_service.rb 82.60% <ø> (ø)
ruby/lib/services/provider_service.rb 64.28% <ø> (ø)
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

@tmarkovski tmarkovski merged commit 60ec732 into main Nov 24, 2022
@tmarkovski tmarkovski deleted the mewmba-generated-protos branch November 24, 2022 14:40
@fundthmcalculus
Copy link
Contributor

Please don't merge when checks are broken. I'll investigate as soon as I get home.

@tmarkovski
Copy link
Member

Please don't merge when checks are broken. I'll investigate as soon as I get home.

I needed the proto files in to publish new .NET fix that I needed for my task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants