-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Speed up the infrastructure testing by removing compiling the CLI (which takes over 3 minutes) #1393
Conversation
…CLI (which takes over 3 minutes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should let people know, and can we confirm that this actually runs grpc 2 (feels weird to direct to a grpc-web samples directory) as well as let the team know? Everyone expects the CLI tests to run, so this is worth notifying in #engineering.
Agreed. I wanted to run it by you before I post it to the broader channel. I should probably rename the folder, since it's really just NPM testing. I specifically went away from the CLI because of the amount of time it takes to run |
CLI can be installed using Homebrew. The service makes bottles for Linux x86 already, so it would just download and use it without compiling. |
brew install actually installs via cargo, which doesn't fix the underlying problem of rust's painfully long compile times. |
ZOOM. 13 seconds to set up homebrew AND the cli. 🚀 |
No description provided.