Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Speed up the infrastructure testing by removing compiling the CLI (which takes over 3 minutes) #1393

Merged
merged 3 commits into from
May 9, 2023

Conversation

fundthmcalculus
Copy link
Member

No description provided.

Copy link
Contributor

@janpieterz janpieterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should let people know, and can we confirm that this actually runs grpc 2 (feels weird to direct to a grpc-web samples directory) as well as let the team know? Everyone expects the CLI tests to run, so this is worth notifying in #engineering.

@fundthmcalculus
Copy link
Member Author

Agreed. I wanted to run it by you before I post it to the broader channel. I should probably rename the folder, since it's really just NPM testing. I specifically went away from the CLI because of the amount of time it takes to run cargo build.

@tmarkovski
Copy link
Member

I specifically went away from the CLI because of the amount of time it takes to run cargo build.

CLI can be installed using Homebrew. The service makes bottles for Linux x86 already, so it would just download and use it without compiling.

@fundthmcalculus
Copy link
Member Author

I specifically went away from the CLI because of the amount of time it takes to run cargo build.

CLI can be installed using Homebrew. The service makes bottles for Linux x86 already, so it would just download and use it without compiling.

brew install actually installs via cargo, which doesn't fix the underlying problem of rust's painfully long compile times.

@tmarkovski
Copy link
Member

brew install actually installs via cargo, which doesn't fix the underlying problem of rust's painfully long compile times.

Only if there's no bottles for the platform. Our CI creates bottles for Linux x86, so this shouldn't build the formula locally, just pull the binary.

@fundthmcalculus
Copy link
Member Author

brew install actually installs via cargo, which doesn't fix the underlying problem of rust's painfully long compile times.

Only if there's no bottles for the platform. Our CI creates bottles for Linux x86, so this shouldn't build the formula locally, just pull the binary.

ZOOM. 13 seconds to set up homebrew AND the cli. 🚀

@fundthmcalculus fundthmcalculus added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 7d1a89f May 9, 2023
3 checks passed
@fundthmcalculus fundthmcalculus deleted the speed-up-test-infra branch May 9, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants