Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login sample python #1394

Merged
merged 6 commits into from
May 8, 2023
Merged

Login sample python #1394

merged 6 commits into from
May 8, 2023

Conversation

fundthmcalculus
Copy link
Member

@fundthmcalculus fundthmcalculus commented May 8, 2023 •
edited

  • This is an updated login sample I wrote which caught some of the issues with the new walletAuthenticate and walletConfirm workflow.

@fundthmcalculus fundthmcalculus marked this pull request as ready for review May 8, 2023 01:53
@fundthmcalculus fundthmcalculus requested a review from a team May 8, 2023 01:54
janpieterz
janpieterz approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@janpieterz janpieterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but maybe feels better as an integration test in the server?

@fundthmcalculus fundthmcalculus added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit 9712bd0 May 8, 2023
10 checks passed
@fundthmcalculus fundthmcalculus deleted the login-sample-python branch May 8, 2023 10:01
@fundthmcalculus
Copy link
Member Author

I specifically have it not as an integration test because I want to use it for customer side testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpieterz janpieterz janpieterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fundthmcalculus @janpieterz