Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Cache NPM dependencies for performance #1395

Merged
merged 3 commits into from
May 10, 2023
Merged

build: Cache NPM dependencies for performance #1395

merged 3 commits into from
May 10, 2023

Conversation

fundthmcalculus
Copy link
Member

@fundthmcalculus fundthmcalculus commented May 10, 2023 •
edited

Speed up the playwright UI tests by cutting the 55 seconds of npm install to [ ]

  • Time it to ensure it's faster

@fundthmcalculus fundthmcalculus marked this pull request as draft May 10, 2023 10:34
@fundthmcalculus fundthmcalculus requested a review from a team May 10, 2023 10:39
@fundthmcalculus
Copy link
Member Author

Doesn't look like much on direct run, will check with a server-api deploy and confirm.

@fundthmcalculus fundthmcalculus marked this pull request as ready for review May 10, 2023 11:09
@fundthmcalculus fundthmcalculus added this pull request to the merge queue May 10, 2023
Merged via the queue into main with commit 43f6080 May 10, 2023
3 checks passed
@fundthmcalculus fundthmcalculus deleted the fundthmcalculus-patch-1 branch May 10, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpieterz janpieterz janpieterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fundthmcalculus @janpieterz