Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs improvements #1488

Merged
merged 25 commits into from
Sep 22, 2023
Merged

Docs improvements #1488

merged 25 commits into from
Sep 22, 2023

Conversation

chiarapaskulin
Copy link
Contributor

No description provided.

@chiarapaskulin chiarapaskulin marked this pull request as ready for review September 6, 2023 20:16
@chiarapaskulin
Copy link
Contributor Author

Not ready for review yet. Just marked it as ready for review to see mewmba's docs previews :) (thanks steven @fundthmcalculus for those! <3 )

@tmarkovski tmarkovski requested a review from a team September 7, 2023 16:25
@tmarkovski
Copy link
Member

Why isn't the docs preview action firing?

@fundthmcalculus
Copy link
Contributor

Why isn't the docs preview action firing?

I need to get the new mkdocs-material token in.

Copy link
Contributor

@lucasamonrc lucasamonrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the same things that @tmarkovski pointed out so I will not give a explicit approval for now. But once those comments are addressed I'll approve it.

@fundthmcalculus
Copy link
Contributor

@chiarapaskulin your demo docs site is up!

Just making a commit to trigger docs build
mkdocs.yml Outdated Show resolved Hide resolved
@trinsic-id trinsic-id deleted a comment from github-actions bot Sep 15, 2023
@trinsic-id trinsic-id deleted a comment from github-actions bot Sep 15, 2023
@trinsic-id trinsic-id deleted a comment from github-actions bot Sep 15, 2023
@trinsic-id trinsic-id deleted a comment from github-actions bot Sep 15, 2023
@chiarapaskulin chiarapaskulin added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 8b48c66 Sep 22, 2023
@chiarapaskulin chiarapaskulin deleted the cp/docs-improvements branch September 22, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants