Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs PR preview #1527

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix docs PR preview #1527

merged 1 commit into from
Sep 22, 2023

Conversation

geel9
Copy link
Member

@geel9 geel9 commented Sep 22, 2023 •
edited

  • This originally broke out of the blue around August 14; I created Fix docs preview action #1494 to fix
    • This restored proper functionality until September 15, when it broke again
  • I've narrowed this down to a netlify-cli bug regarding how the --dir flag was handled
    • My Fix docs preview action #1494 worked around this introduced bug, though I didn't know where the actual issue was coming from at the time
    • netlify-cli was recently patched to fix the underlying bug, meaning that my workaround became a bug itself

@github-actions
Copy link
Contributor

Preview docs site for JC/fix-netlify-again@54ef200b
Changed paths:

@geel9 geel9 added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 0d3598b Sep 22, 2023
2 checks passed
@geel9 geel9 deleted the JC/fix-netlify-again branch September 22, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasamonrc lucasamonrc lucasamonrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geel9 @lucasamonrc