Wallet API Docs Improvements #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
janpieterz
previously requested changes
Oct 24, 2023
tmarkovski
reviewed
Oct 24, 2023
tmarkovski
reviewed
Oct 24, 2023
Co-authored-by: Jan-Pieter George <jp@trinsic.id>
Co-authored-by: Jan-Pieter George <jp@trinsic.id>
Co-authored-by: Jan-Pieter George <jp@trinsic.id>
Co-authored-by: Jan-Pieter George <jp@trinsic.id>
Co-authored-by: Jan-Pieter George <jp@trinsic.id>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lucasamonrc
reviewed
Oct 24, 2023
lucasamonrc
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
I'd wait for @janpieterz or @tmarkovski before merging just to be more thorough since I think docs work is a highly subjective business (your call). Looks good to me.
chiarapaskulin
dismissed
janpieterz’s stale review
Already fixed all the requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs part of https://github.com/trinsic-id/server/issues/2132 and https://github.com/trinsic-id/server/pull/2898