Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add HasValidCredential method to the ConnectService #1585

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

mewmba
Copy link
Contributor

@mewmba mewmba commented Nov 30, 2023

feature: Add HasValidCredential method to the ConnectService (#3094) * Validate issuer is signer * Validate credential has valid status * Fix build error * Create credential proof and verify it before sending back to client * Add todos * Fix finalize session bug * Add simple unit test for new normalization method * Refactor CredentialNormalization to use new method * Issue a single auth token to be used in the multi-ecosystem lookup * Apply formatting changes * Remove deprecated todo * Fix tests * Revert validation tests change * Change "whoops" error messages * spike: HasValidCredential sdk method * Add tests for HasValidCredential * Apply formatting changes * Fix merge errors * Improve test data to be more reliable * Make sure tests are idempotent --------- Co-authored-by: Mewmba mewmba@trinsic.id

@lucasamonrc lucasamonrc added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 892feee Nov 30, 2023
@lucasamonrc lucasamonrc deleted the mewmba/main-6f1025a4-generated-protos branch November 30, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants