-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple C# Added to Walkthrough #30
Conversation
This PR can be reviewed in Gitpod |
docs/walkthrough.md
Outdated
If you're running this locally, you'll need to first install [rust](https://www.rust-lang.org/tools/install). Once installed run `cargo install --path .` in the `cli` directory. | ||
## 0. Install Trinsic | ||
Before we start, make sure you have an SDK installed. | ||
=== "CLI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like not having to make the user open a new tab for the install instructions, so I made each of these snippets. As we write how-to guides for different languages, I think these will come in handy. We could still just link to the install page in the future, but it was trivial to import the snippets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use "Trinsic CLI" universally as the tab name? That way, it get's persisted and applied everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't "Trinsic CLI" kind of redundant? Because it's implied they're on Trinsic's docs site, I felt CLI was better. Thoughts?
.gitignore
Outdated
@@ -343,4 +343,6 @@ Cargo.lock | |||
.DS_Store | |||
|
|||
.ionide | |||
|
|||
Trinsic.IntegrationTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this ignoring?
docs/walkthrough.md
Outdated
If you're running this locally, you'll need to first install [rust](https://www.rust-lang.org/tools/install). Once installed run `cargo install --path .` in the `cli` directory. | ||
## 0. Install Trinsic | ||
Before we start, make sure you have an SDK installed. | ||
=== "CLI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use "Trinsic CLI" universally as the tab name? That way, it get's persisted and applied everywhere.
mkdocs.yml
Outdated
@@ -42,14 +44,16 @@ theme: | |||
icon: fontawesome/solid/sun | |||
name: Switch to light mode | |||
markdown_extensions: | |||
- pymdownx.highlight | |||
- pymdownx.highlight: | |||
linenums: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this can be enabled on per code block bases, that's be better. A lot of our snippets are one liners, and the "1" everywhere looked unnecessary, especially in script blocks, where it makes less sense.
* clarify index * added csharp and annotations * added c# script * pr changes Co-authored-by: Michael Boyd <michael@trinsic.id>
TODOs