Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple C# Added to Walkthrough #30

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Simple C# Added to Walkthrough #30

merged 6 commits into from
Jun 4, 2021

Conversation

michaeldboyd
Copy link
Member

  • clarify index
  • added csharp and annotations
  • added c# script

TODOs

  • Make c# scripts use vaccination files
  • make a runnable c# script

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

This PR can be reviewed in Gitpod

cli/src/proto/trinsic_services.rs Show resolved Hide resolved
If you're running this locally, you'll need to first install [rust](https://www.rust-lang.org/tools/install). Once installed run `cargo install --path .` in the `cli` directory.
## 0. Install Trinsic
Before we start, make sure you have an SDK installed.
=== "CLI"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like not having to make the user open a new tab for the install instructions, so I made each of these snippets. As we write how-to guides for different languages, I think these will come in handy. We could still just link to the install page in the future, but it was trivial to import the snippets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use "Trinsic CLI" universally as the tab name? That way, it get's persisted and applied everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't "Trinsic CLI" kind of redundant? Because it's implied they're on Trinsic's docs site, I felt CLI was better. Thoughts?

.gitignore Outdated
@@ -343,4 +343,6 @@ Cargo.lock
.DS_Store

.ionide

Trinsic.IntegrationTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this ignoring?

If you're running this locally, you'll need to first install [rust](https://www.rust-lang.org/tools/install). Once installed run `cargo install --path .` in the `cli` directory.
## 0. Install Trinsic
Before we start, make sure you have an SDK installed.
=== "CLI"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use "Trinsic CLI" universally as the tab name? That way, it get's persisted and applied everywhere.

mkdocs.yml Outdated
@@ -42,14 +44,16 @@ theme:
icon: fontawesome/solid/sun
name: Switch to light mode
markdown_extensions:
- pymdownx.highlight
- pymdownx.highlight:
linenums: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this can be enabled on per code block bases, that's be better. A lot of our snippets are one liners, and the "1" everywhere looked unnecessary, especially in script blocks, where it makes less sense.

@michaeldboyd michaeldboyd merged commit d9b6dcb into main Jun 4, 2021
@fundthmcalculus fundthmcalculus deleted the mdb/concepts-update branch June 26, 2021 20:41
tmarkovski pushed a commit that referenced this pull request Oct 29, 2021
* clarify index

* added csharp and annotations

* added c# script

* pr changes

Co-authored-by: Michael Boyd <michael@trinsic.id>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants