Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby Refactor and Demo Extraction with Request Response structure update #506

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Ruby Refactor and Demo Extraction with Request Response structure update #506

merged 5 commits into from
Mar 24, 2022

Conversation

fundthmcalculus
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2022 •
edited

Ruby Test Report

  6 files   -   3    6 suites   - 3   31s ⏱️ -38s
  8 tests +  1    8 ✔️ +  2  0 💤 ±0  0 ❌ ±0 
48 runs   - 15  48 ✔️  - 14  0 💤 ±0  0 ❌ ±0 

Results for commit d2ac42b. ± Comparison against base commit ffec37b.

♻️ This comment has been updated with latest results.

@fundthmcalculus
updated require definitions
6f3f00d 
refactored demo samples
@fundthmcalculus fundthmcalculus marked this pull request as ready for review March 24, 2022 14:44
@fundthmcalculus fundthmcalculus enabled auto-merge (squash) March 24, 2022 15:12
@fundthmcalculus fundthmcalculus changed the title Sdk 479 ruby request response Ruby Refactor and Demo Extraction Mar 24, 2022
@fundthmcalculus
Copy link
Contributor Author

This works on staging on my machine, the github action runner is acting up.

@fundthmcalculus fundthmcalculus mentioned this pull request Mar 24, 2022
Closed
8 tasks
@fundthmcalculus fundthmcalculus changed the title Ruby Refactor and Demo Extraction Ruby Refactor and Demo Extraction with Request Response structure update Mar 24, 2022
@fundthmcalculus fundthmcalculus linked an issue Mar 24, 2022 that may be closed by this pull request
Ensure every language uses the Request and Response structure objects #479
Closed
8 tasks
@fundthmcalculus fundthmcalculus merged commit 1ae9cd8 into main Mar 24, 2022
@fundthmcalculus fundthmcalculus deleted the sdk-479-ruby-request-response branch March 24, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkovski tmarkovski tmarkovski approved these changes

@michaeldboyd michaeldboyd Awaiting requested review from michaeldboyd

@MichaelEdwardBlack MichaelEdwardBlack Awaiting requested review from MichaelEdwardBlack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure every language uses the Request and Response structure objects
2 participants
@fundthmcalculus @tmarkovski