Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-590] wrap metadata calls for node and web #592

Merged
merged 6 commits into from
Apr 21, 2022
Merged

[SDK-590] wrap metadata calls for node and web #592

merged 6 commits into from
Apr 21, 2022

Conversation

fundthmcalculus
Copy link
Contributor

@fundthmcalculus fundthmcalculus commented Apr 20, 2022 •
edited

closes #590

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022 •
edited

Golang Test Report

  2 files    2 suites   12s ⏱️
12 tests 11 ✔️ 0 💤 1 ❌
24 runs  22 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit b2cff4c.

♻️ This comment has been updated with latest results.

@fundthmcalculus fundthmcalculus changed the title Sdk 590 wrap get metadata calls for node [SDK-590] wrap metadata calls for node and web Apr 20, 2022
@fundthmcalculus fundthmcalculus enabled auto-merge (squash) April 21, 2022 01:11
@fundthmcalculus fundthmcalculus merged commit 961fb9c into main Apr 21, 2022
@fundthmcalculus fundthmcalculus deleted the sdk-590-wrap-get-metadata-calls branch April 21, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkovski tmarkovski tmarkovski approved these changes

@MichaelEdwardBlack MichaelEdwardBlack Awaiting requested review from MichaelEdwardBlack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properly wrap the .getMetadata() call for node and web to handle error rejection being propagated upstream
2 participants
@fundthmcalculus @tmarkovski