Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default limit 100 queries #625

Merged
merged 4 commits into from
May 4, 2022
Merged

default limit 100 queries #625

merged 4 commits into from
May 4, 2022

Conversation

fundthmcalculus
Copy link
Contributor

closes #597

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022 •
edited
Loading

Python Test Report

  9 files    9 suites   1m 57s ⏱️
11 tests 10 ✔️ 0 💤 1 ❌
99 runs  98 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit c9bc7c4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022 •
edited
Loading

Golang Test Report

  2 files    2 suites   13s ⏱️
12 tests 12 ✔️ 0 💤 0 ❌
24 runs  24 ✔️ 0 💤 0 ❌

Results for commit c9bc7c4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022 •
edited
Loading

Java Test Report

  9 files    9 suites   53s ⏱️
  9 tests   8 ✔️ 1 💤 0 ❌
27 runs  24 ✔️ 3 💤 0 ❌

Results for commit c9bc7c4.

♻️ This comment has been updated with latest results.

geel9
geel9 approved these changes May 4, 2022
View reviewed changes
docs/reference/services/template-service.md Outdated Show resolved Hide resolved
docs/reference/services/wallet-service.md Outdated Show resolved Hide resolved
fundthmcalculus and others added 2 commits May 4, 2022 16:05
@fundthmcalculus @geel9
Update docs/reference/services/template-service.md
a79f360 
Co-authored-by: Joshua Coffey <josh@trinsic.id>
@fundthmcalculus @geel9
Update docs/reference/services/wallet-service.md
e4fde75 
Co-authored-by: Joshua Coffey <josh@trinsic.id>
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022 •
edited
Loading

Ruby Test Report

  7 files    7 suites   41s ⏱️
  8 tests   8 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit c9bc7c4.

♻️ This comment has been updated with latest results.

fundthmcalculus
fundthmcalculus commented May 4, 2022
View reviewed changes
Copy link
Contributor Author

@fundthmcalculus fundthmcalculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @geel9

cli/src/cli.yaml Outdated Show resolved Hide resolved
cli/src/cli.yaml Outdated Show resolved Hide resolved
cli/src/parser/template.rs Outdated Show resolved Hide resolved
cli/src/parser/template.rs Outdated Show resolved Hide resolved
cli/src/services/trustregistry.rs Outdated Show resolved Hide resolved
java/src/main/java/trinsic/services/WalletService.java Outdated Show resolved Hide resolved
java/src/main/java/trinsic/services/TrustRegistryServiceKt.kt Outdated Show resolved Hide resolved
java/src/main/java/trinsic/services/TrustRegistryService.java Outdated Show resolved Hide resolved
go/services/wallet_service.go Outdated Show resolved Hide resolved
go/services/trustregistry_service.go Outdated Show resolved Hide resolved
@fundthmcalculus fundthmcalculus merged commit d800888 into main May 4, 2022
@fundthmcalculus fundthmcalculus deleted the sdk-597-limit-default-query branch May 4, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geel9 geel9 geel9 approved these changes

@tmarkovski tmarkovski Awaiting requested review from tmarkovski

@MichaelEdwardBlack MichaelEdwardBlack Awaiting requested review from MichaelEdwardBlack

@sethjback sethjback Awaiting requested review from sethjback

@michaeldboyd michaeldboyd Awaiting requested review from michaeldboyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SQL query limit parameter to the search functions
2 participants
@fundthmcalculus @geel9