Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed walkthrough page #629

Merged
merged 4 commits into from
May 17, 2022
Merged

Completed walkthrough page #629

merged 4 commits into from
May 17, 2022

Conversation

MichaelEdwardBlack
Copy link
Contributor

#422

Maybe we can move the replit task in this issue to a separate issue.

@tmarkovski
Copy link
Member

We can punt the replit work for now.

@tmarkovski tmarkovski requested a review from geel9 May 16, 2022 20:57
@geel9
Copy link
Member

geel9 commented May 17, 2022

So, I see the following issues with the walkthrough before we can consider it to be complete:

  • The created Template has different fields based on the language. All languages should be building the exact same Template.
  • After creation of the Ecosystem, we should explain how to use said Ecosystem.
    • For example, by setting ServiceOptions.DefaultEcosystem
  • Creation of the Ecosystem should be the first step in the tutorial; before the creation of the accounts. The Accounts, and the Template, need to be created within the Ecosystem.
  • Either prepare the Replits and link them, or remove the text about the Replits until they exist.

@geel9
Copy link
Member

geel9 commented May 17, 2022

I'm comfortable taking on the above issues.

I'd prefer to issue a PR into this branch, and then merge this PR into main, rather than merging this PR immediately.

I'll do that tomorrow (the 17th).

@geel9
Copy link
Member

geel9 commented May 17, 2022

Upon further review, the issues with the walkthrough are more extensive than I initially thought; I've created a separate tracking issue here: #659

I'll be merging this PR to clear it from the queue, and will create a new PR against the above issue later.

docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
docs/walkthroughs/vaccination.md Outdated Show resolved Hide resolved
@geel9 geel9 merged commit ae993e5 into main May 17, 2022
@geel9 geel9 deleted the Black/complete-walkthrough branch May 17, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants