Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark TemplateService.List as an experimental endpoint #630

Merged
merged 1 commit into from
May 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ on:
jobs:
build_test:
name: Test
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
target: [ "web" ]
node-version: [ 14, 16 ]
node-http-protocol: ["true", "false"]
Expand Down
2 changes: 2 additions & 0 deletions dotnet/Trinsic/TemplateService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,12 @@ internal TemplateService(ITokenProvider tokenProvider, IOptions<ServiceOptions>
/// <returns>
/// The search response and continuation token, if available
/// </returns>
[Experimental]
public async Task<ListCredentialTemplatesResponse> ListAsync(ListCredentialTemplatesRequest request) {
return await Client.ListAsync(request, await BuildMetadataAsync(request));
}

[Experimental]
public ListCredentialTemplatesResponse List(ListCredentialTemplatesRequest request) {
return Client.List(request, BuildMetadata(request));
}
Expand Down
2 changes: 1 addition & 1 deletion web/test/env.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ServiceOptions } from "../src";
import ServiceBase from "../lib/ServiceBase";
import ServiceBase from "../src/ServiceBase";

function isNode(): boolean {
// TODO - Refactor this into one location, utility class?
Expand Down