Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaccine walkthrough improvements #664

Merged
merged 23 commits into from
May 23, 2022
Merged

Vaccine walkthrough improvements #664

merged 23 commits into from
May 23, 2022

Conversation

geel9
Copy link
Member

@geel9 geel9 commented May 23, 2022

Overview

This PR (apologies for the size) makes the following improvements to the vaccine walkthrough (tracked from #659)

  • Ecosystem creation is now explained and is the first step
    • Ecosystem creation now has a sub-step, which is setting the created ecosystem as the default ecosystem in CLI and SDKs
  • Normalized / fixed template schema between Typescript and CLI
    • Other languages pending
  • Credential is now issued using IssueFromTemplate, instead of using a raw pre-prepared VC JSON-LD document.
    • Only for CLI and Typescript; other languages pending
  • Proof is generated for entire credential, not a subset
    • Removes need to go over JSON-LD frames in walkthrough, simplifying happy path
    • Added an infobox informing users of ability to generate selective proofs, prompting them to read more about it
    • Only for CLI and Typescript; other languages pending
  • Explanatory prose added to Define a Template section
  • Replit text hidden (until we actually have replits)
  • Fixed incorrect CLI commands (--alias, --profile, etc. don't exist)
  • Prose pass on Send Credential to Allison and Create Accounts sections
  • Misc. smaller tweaks

There is still more to be done, but the PR is already quite large, so I'll push this one first.

@geel9 geel9 merged commit 4985197 into main May 23, 2022
@geel9 geel9 deleted the JC/walkthrough-fixes branch May 23, 2022 20:45
@geel9 geel9 restored the JC/walkthrough-fixes branch May 25, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants