Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Sample Improvements #675

Merged
merged 7 commits into from
May 25, 2022
Merged

Python Sample Improvements #675

merged 7 commits into from
May 25, 2022

Conversation

geel9
Copy link
Member

@geel9 geel9 commented May 25, 2022

Main Changes

  • credential-service.md and wallet-service.md no longer inject from vaccine_demo.py
    • credential_demo.py and wallet_demo.py test files created to inject from
  • vaccination.md now only injects from vaccine_demo.py
  • vaccine_demo.py updated to fit new flow of walkthrough
    • Credential is no longer issued from prepared JSON file but rather from a template
    • Credential no longer has a selective proof created for it

Misc Changes

  • Commented out Ruby code tab at top of page; it was the only code tab to include this language.
  • Fixed Python docs; correct install verification command is python -m trinsic, not python -m trinsic-sdk

@github-actions
Copy link
Contributor

Python Test Report

  9 files    9 suites   1m 58s ⏱️
11 tests 11 ✔️ 0 💤 0
99 runs  99 ✔️ 0 💤 0

Results for commit 75be745.

@geel9 geel9 merged commit fcda214 into main May 25, 2022
@geel9 geel9 deleted the JC/walkthrough-python-fixes branch May 25, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants