Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Vaccine Walkthrough Fixes #686

Merged
merged 9 commits into from
May 27, 2022
Merged

Java Vaccine Walkthrough Fixes #686

merged 9 commits into from
May 27, 2022

Conversation

geel9
Copy link
Member

@geel9 geel9 commented May 27, 2022

Main Changes

  • Created CredentialsDemo.java and WalletsDemo.java
    • credential-service.md and wallet-service.md now inject from these files instead of VaccineDemo.java
  • Updated VaccineDemo.java in line with new changes

Misc Changes

  • Removed line from templates-service.md indicating that the Verifiable Presentation Request Specification would be usable to query templates in future
    • Seems like an oversight -- likely copied over from the same section in wallet-service.md
  • Added serviceBase.setDefaultEcosystem() method

@geel9 geel9 merged commit c780313 into main May 27, 2022
@geel9 geel9 deleted the JC/walkthrough-java-fixes branch May 27, 2022 20:05
Copy link
Contributor

@fundthmcalculus fundthmcalculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit comment checks out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants