Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang single service #704

Merged
merged 6 commits into from
Jun 7, 2022
Merged

Golang single service #704

merged 6 commits into from
Jun 7, 2022

Conversation

sethjback
Copy link
Contributor

This draft is a proposal for 2 things:

  1. Fixing the package namespace issue in the protobuf. Ideally this will be pushed to a separate PR, it is included here simply to make everything work.
  2. Creates a trinsic-service that wraps all the individual services

This is intended mostly to encourage feedback on the wrapper service

fundthmcalculus
fundthmcalculus approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@fundthmcalculus fundthmcalculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I like this. Except for the singular/plural issue, which might just be a personal preference.

@fundthmcalculus
Merge branch 'main' into golan-single-service
6e5a640 
# Conflicts:
#	go/proto/provider/v1/provider.pb.go
#	go/proto/services/verifiablecredentials/templates/v1/template/templates.pb.go
#	go/proto/services/verifiablecredentials/templates/v1/template/templates_grpc.pb.go
#	go/proto/services/verifiablecredentials/v1/credential/verifiable-credentials.pb.go
#	go/proto/services/verifiablecredentials/v1/credential/verifiable-credentials_grpc.pb.go
#	go/services/account_service.go
#	go/services/account_service_test.go
#	go/services/credential_service.go
#	go/services/credentialtemplate_service.go
#	go/services/credentialtemplate_service_test.go
#	go/services/provider_service.go
#	go/services/services.go
#	go/services/trustregistry_service.go
#	go/services/wallet_service.go
@fundthmcalculus
Fix proto issues
3a58af6
@fundthmcalculus
Only download plugins if asked.
9e4adc7
@fundthmcalculus fundthmcalculus marked this pull request as ready for review June 7, 2022 17:02
@fundthmcalculus fundthmcalculus self-requested a review June 7, 2022 17:05
fundthmcalculus
fundthmcalculus suggested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@fundthmcalculus fundthmcalculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until @sethjback has time to confirm I didn't break anything

@sethjback
Copy link
Contributor Author

Looks good to me

@fundthmcalculus fundthmcalculus enabled auto-merge (squash) June 7, 2022 17:08
@fundthmcalculus fundthmcalculus self-requested a review June 7, 2022 17:08
@fundthmcalculus fundthmcalculus merged commit 0901e68 into main Jun 7, 2022
@fundthmcalculus fundthmcalculus deleted the golan-single-service branch June 7, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fundthmcalculus fundthmcalculus fundthmcalculus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethjback @fundthmcalculus