Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 1.6.0 Docs & Samples/Tests #745

Merged
merged 17 commits into from
Jun 29, 2022
Merged

SDK 1.6.0 Docs & Samples/Tests #745

merged 17 commits into from
Jun 29, 2022

Conversation

geel9
Copy link
Member

@geel9 geel9 commented Jun 13, 2022

Overview

This PR exists to collate all 1.6.0-related documentation changes, which necessarily includes changes to the injected tests, for code samples.

Work on documentation and tests should be done in branches based off of this branch, and PRs created to merge back into this branch.

Once 1.6.0 is released, we can merge this single PR to update all our documentation in one go.

Languages To-do

  • .NET

  • Go

  • Java

  • Python

  • Web

@geel9 geel9 requested a review from michaeldboyd as a code owner June 13, 2022 17:55
@geel9 geel9 added documentation Improvements or additions to documentation golang Issue is related to the Go sdk dotnet Issue is related to the .NET sdk javascript Pull requests that update Javascript code labels Jun 13, 2022
@fundthmcalculus fundthmcalculus marked this pull request as draft June 17, 2022 16:11
@geel9 geel9 added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation golang Issue is related to the Go sdk dotnet Issue is related to the .NET sdk javascript Pull requests that update Javascript code labels Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #745 (50d150e) into main (1b9894b) will increase coverage by 52.08%.
The diff coverage is 96.00%.

❗ Current head 50d150e differs from pull request most recent head 5db918f. Consider uploading reports for the commit 5db918f to get more accurate results

@@              Coverage Diff              @@
##               main     #745       +/-   ##
=============================================
+ Coverage     15.11%   67.20%   +52.08%     
=============================================
  Files           268       54      -214     
  Lines         41403     3101    -38302     
  Branches       4357        0     -4357     
=============================================
- Hits           6260     2084     -4176     
+ Misses        34600      945    -33655     
+ Partials        543       72      -471     
Impacted Files Coverage Δ
python/samples/account_demo.py 92.59% <92.59%> (ø)
python/samples/provider_demo.py 93.54% <100.00%> (+6.88%) ⬆️
python/tests/test_trinsic_services.py 98.59% <100.00%> (+0.06%) ⬆️
...net/Trinsic/Extensions/ServiceOptionsExtensions.cs 25.00% <0.00%> (-75.00%) ⬇️
...iablecredentials/v1/IssueFromTemplateResponse.java
...fiablecredentials/v1/IssueFromTemplateRequest.java
.../src/proto/services/account/v1/account.pbgrpc.dart
...niversal-wallet/v1/universal-wallet_services_pb.rb
.../services/provider/v1/InvitationStatusRequest.java
...nsic/services/account/v1/LoginConfirmResponse.java
... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9894b...5db918f. Read the comment docs.

@geel9 geel9 marked this pull request as ready for review June 29, 2022 15:18
@geel9 geel9 merged commit 5a808c5 into main Jun 29, 2022
@geel9 geel9 deleted the 1.6.0-docs-tests branch June 29, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants