New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add `LoginAnonymous`, refactor `LoginConfirm` (per #750) #752

Merged

fundthmcalculus merged 2 commits into main from JC/go-loginconfirm-anonymous

Jun 14, 2022

Member

geel9 commented Jun 14, 2022 •

edited

Adds LoginAnonymous
Refactors LoginConfirm to handle hashing/unprotection for caller

All per #750

Questions (I am new to Go)

Is the way I converted authCode to a byte array (account_service.go, line 170) correct?
- Does this handle character encoding in the way one might expect?
Am I creating errors correctly?

geel9 added 2 commits

June 14, 2022 11:28


          Fix typos

708323b


          Add LoginAnonymous, refactor LoginConfirm

c4d1023

geel9 requested review from fundthmcalculus and sethjback as code owners

June 14, 2022 15:32

geel9 mentioned this pull request

Add LoginAnonymous, proper LoginConfirm functionality #750

Closed

9 tasks

fundthmcalculus approved these changes

View reviewed changes

fundthmcalculus merged commit 6586cfd into main

fundthmcalculus deleted the JC/go-loginconfirm-anonymous branch

June 14, 2022 17:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment