Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commonjs module support #847

Merged
merged 5 commits into from Jul 8, 2022
Merged

Conversation

fundthmcalculus
Copy link
Member

@fundthmcalculus fundthmcalculus commented Jul 6, 2022

Relates to #838, won't close issue until we confirm it is fixed for customers
We should have most tests pass, a couple will fail with "credential has no issuer", but that's a separate problem

@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com July 6, 2022 20:24 Inactive
@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com July 8, 2022 01:06 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #847 (184b605) into main (feb9ff6) will increase coverage by 63.51%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main     #847       +/-   ##
=============================================
+ Coverage     16.64%   80.15%   +63.51%     
=============================================
  Files           259       30      -229     
  Lines         41182     1885    -39297     
  Branches       4348        0     -4348     
=============================================
- Hits           6853     1511     -5342     
+ Misses        33646      374    -33272     
+ Partials        683        0      -683     
Impacted Files Coverage Δ
python/samples/credential_demo.py 94.73% <100.00%> (ø)
python/trinsic/trinsic_util.py 66.66% <0.00%> (-3.34%) ⬇️
python/trinsic/proto/services/options/__init__.py 0.00% <0.00%> (ø)
...ython/trinsic/proto/services/common/v1/__init__.py 100.00% <0.00%> (ø)
...thon/trinsic/proto/services/account/v1/__init__.py 82.10% <0.00%> (ø)
...n/trinsic/proto/trinsic/services/event/__init__.py 0.00% <0.00%> (ø)
...roto/services/verifiablecredentials/v1/__init__.py 77.77% <0.00%> (ø)
...ces/verifiablecredentials/templates/v1/__init__.py 84.41% <0.00%> (ø)
...n/java/trinsic/services/provider/v1/Ecosystem.java
...rinsic/services/account/v1/AccountInfoRequest.java
... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb9ff6...184b605. Read the comment docs.

@fundthmcalculus fundthmcalculus merged commit 31fde3b into main Jul 8, 2022
@fundthmcalculus fundthmcalculus deleted the sdk-838-commonjs-module branch July 8, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants