Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java updates with metadata options #862

Merged
merged 2 commits into from Jul 11, 2022
Merged

Conversation

fundthmcalculus
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #862 (309b4ae) into main (6540d3c) will decrease coverage by 29.61%.
The diff coverage is 68.75%.

@@              Coverage Diff              @@
##               main     #862       +/-   ##
=============================================
- Coverage     40.08%   10.46%   -29.62%     
- Complexity        0      854      +854     
=============================================
  Files            99      158       +59     
  Lines          8979    31457    +22478     
  Branches          0     4256     +4256     
=============================================
- Hits           3599     3292      -307     
- Misses         5300    27559    +22259     
- Partials         80      606      +526     
Impacted Files Coverage Δ
...src/main/java/trinsic/services/AccountServiceKt.kt 0.00% <ø> (ø)
.../main/java/trinsic/services/CredentialServiceKt.kt 0.00% <ø> (ø)
...rc/main/java/trinsic/services/ProviderServiceKt.kt 0.00% <ø> (ø)
...rc/main/java/trinsic/services/TemplateServiceKt.kt 0.00% <ø> (ø)
...in/java/trinsic/services/TrustRegistryServiceKt.kt 0.00% <ø> (ø)
.../src/main/java/trinsic/services/WalletServiceKt.kt 0.00% <ø> (ø)
...src/main/java/trinsic/services/AccountService.java 80.48% <25.00%> (ø)
...rc/main/java/trinsic/services/ProviderService.java 57.69% <50.00%> (ø)
.../src/main/java/trinsic/services/WalletService.java 75.00% <50.00%> (ø)
...va/src/main/java/trinsic/services/ServiceBase.java 80.00% <80.00%> (ø)
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6540d3c...309b4ae. Read the comment docs.

@geel9 geel9 self-requested a review July 11, 2022 15:00
Copy link
Member

@geel9 geel9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata should be built for every request (incl. Login, LoginConfirm, CreateEcosystem)

Copy link
Member

@geel9 geel9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous comment will be resolved in a separate PR.

@fundthmcalculus fundthmcalculus merged commit 50db73d into main Jul 11, 2022
@fundthmcalculus fundthmcalculus deleted the SDK-845-Java-agent-headers branch July 11, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants