Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts][go] Add memory token provider for storing auth tokens #901

Merged
merged 4 commits into from Jul 28, 2022

Conversation

fundthmcalculus
Copy link
Member

This is better done before the node/web SDK package changes, so here's the PR for go and typescript. Not a blocker for release of 1.7.0, but nice to have.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #901 (6fbdbc2) into main (224a631) will increase coverage by 44.03%.
The diff coverage is 34.61%.

❗ Current head 6fbdbc2 differs from pull request most recent head cf866ce. Consider uploading reports for the commit cf866ce to get more accurate results

@@            Coverage Diff            @@
##           main     #901       +/-   ##
=========================================
+ Coverage      0   44.03%   +44.03%     
=========================================
  Files         0       14       +14     
  Lines         0     1022     +1022     
=========================================
+ Hits          0      450      +450     
- Misses        0      489      +489     
- Partials      0       83       +83     
Impacted Files Coverage Δ
go/services/account_service.go 40.28% <16.66%> (ø)
go/services/token_provider.go 30.76% <30.76%> (ø)
go/services/service_base.go 61.62% <57.14%> (ø)
go/services/template_service.go 30.30% <0.00%> (ø)
go/services/security.go 65.71% <0.00%> (ø)
go/services/trustregistry_service.go 34.40% <0.00%> (ø)
go/services/loadcerts.go 0.00% <0.00%> (ø)
go/services/provider_service.go 32.73% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224a631...cf866ce. Read the comment docs.

@tmarkovski tmarkovski changed the title Sdk 856 memorytokenprovider [ts][go] Add memory token provider for storing auth tokens Jul 28, 2022
@fundthmcalculus fundthmcalculus enabled auto-merge (squash) July 28, 2022 13:37
@fundthmcalculus fundthmcalculus merged commit e737bc9 into main Jul 28, 2022
@fundthmcalculus fundthmcalculus deleted the sdk-856-memorytokenprovider branch July 28, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants