New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdk 895 allow direct imports #902
Conversation
… warning about `return await`.
# Conflicts: # web/src/AccountService.ts # web/src/ServiceBase.ts
Will trigger another rc for this, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great :)
…er");` to `require("@trinsic/trinsic/browser");`
I am dealing with some interesting alias import issues, but nothing that would totally block release. |
Codecov Report
@@ Coverage Diff @@
## main #902 +/- ##
=========================================
- Coverage 44.03% 0 -44.04%
=========================================
Files 14 0 -14
Lines 1022 0 -1022
=========================================
- Hits 450 0 -450
+ Misses 489 0 -489
+ Partials 83 0 -83 Continue to review full report at Codecov.
|
This reverts commit a845bd3.
Persuant to the comment shown here: #895 (comment) this is a version of SDK node/web which allows direct import overriding, without the package split or the webpack poisoning.