Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk 895 allow direct imports #902

Merged
merged 15 commits into from Jul 29, 2022
Merged

Conversation

fundthmcalculus
Copy link
Member

Persuant to the comment shown here: #895 (comment) this is a version of SDK node/web which allows direct import overriding, without the package split or the webpack poisoning.

@fundthmcalculus fundthmcalculus marked this pull request as ready for review July 28, 2022 14:05
@tmarkovski tmarkovski requested a review from geel9 July 28, 2022 14:23
@fundthmcalculus
Copy link
Member Author

Will trigger another rc for this, 1.7.0-rc1, and test it. If it works, I'll merge this before 1.7.0 release.

Copy link
Contributor

@janpieterz janpieterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great :)

@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com July 28, 2022 21:11 Inactive
@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com July 29, 2022 02:52 Inactive
@fundthmcalculus
Copy link
Member Author

Will trigger another rc for this, 1.7.0-rc1, and test it. If it works, I'll merge this before 1.7.0 release.

I am dealing with some interesting alias import issues, but nothing that would totally block release.

@codecov-commenter
Copy link

Codecov Report

Merging #902 (553d80c) into main (e737bc9) will decrease coverage by 44.03%.
The diff coverage is n/a.

❗ Current head 553d80c differs from pull request most recent head 44344bf. Consider uploading reports for the commit 44344bf to get more accurate results

@@            Coverage Diff            @@
##             main   #902       +/-   ##
=========================================
- Coverage   44.03%      0   -44.04%     
=========================================
  Files          14      0       -14     
  Lines        1022      0     -1022     
=========================================
- Hits          450      0      -450     
+ Misses        489      0      -489     
+ Partials       83      0       -83     
Impacted Files Coverage Δ
go/services/trinsic_service.go
go/services/trustregistry_service.go
go/services/storage.go
go/services/services.go
go/services/loadcerts.go
go/services/provider_service.go
go/services/service_base.go
go/services/token_provider.go
go/services/security.go
go/services/loadcerts_windows.go
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e737bc9...44344bf. Read the comment docs.

@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com July 29, 2022 16:24 Inactive
@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com July 29, 2022 17:07 Inactive
@fundthmcalculus fundthmcalculus merged commit a3a32ad into main Jul 29, 2022
@fundthmcalculus fundthmcalculus deleted the sdk-895-allow-direct-importsd branch July 29, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants