Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication page layout is a mess after first installation #496

Closed
spficklin opened this issue Jun 30, 2018 · 4 comments
Closed

Publication page layout is a mess after first installation #496

spficklin opened this issue Jun 30, 2018 · 4 comments
Assignees
Labels
bug - confirmed For issues where a core developer has confirmed a bug exists. Release Blocker Any issue which needs to be addressed before another version of Tripal can be released. Tripal 3 Any issue or pull requuest focused on Tripal 3

Comments

@spficklin
Copy link
Member

spficklin commented Jun 30, 2018

BUG/ERROR report

System information

  • Tripal Version: 3.x
  • Drupal Version: 7.x
  • PostgreSQL Version: N/A
  • PHP Version: 7.2

Issue description

On a fresh in stall of Tripal, when following the online User's Guide it instructions the user to add a publication. After saving the publication many of the fields are not in a Tripal Pane and it looks like a mess:

screenshot from 2018-06-29 20-11-14

If I go back to the Publication content type and re-apply the default layout and click "Save" then it fixes the problem. Those fields that are showing up without being in a Tripal Pane look like they are disabled but they still show up.

@spficklin spficklin added bug - confirmed For issues where a core developer has confirmed a bug exists. Tripal 3 Any issue or pull requuest focused on Tripal 3 Release Blocker Any issue which needs to be addressed before another version of Tripal can be released. labels Jun 30, 2018
@shawnawsu
Copy link
Member

@spficklin

Publication is the only content type with custom handling in the tripal_ds module. It looks like a bunch of field names changed, did that happen? If it did, can we connect to go over the new preferred layout?

@spficklin
Copy link
Member Author

I don't know how field names changed. Do you know the before and after names of the fields? Let's chat when I'm back in town.

@shawnawsu shawnawsu mentioned this issue Jul 18, 2018
8 tasks
@shawnawsu
Copy link
Member

Apparently, there was a problem with my local, when I delete the publication content type and rebuilt it half the fields disappeared which is why I thought fields were renamed. They are not renamed, they just disappeared.

Given that I had another look and found the problem. I pushed a fix in pull request #508.

@laceysanderson
Copy link
Member

laceysanderson commented Jul 19, 2018

Merged PR fixes the publication page so it's no longer a mess 👍

I wonder if we shouldn't discuss a better default though. I think it would be pretty generic to change the settings as follows and it would show a lot more information by default. Currently it's annoying for an admin to drag every single chado property into a pane ;-) (screenshot of settings)

  • pull the abstract out of the summary table but within the summary pane
  • show all other chado property fields in an "Metadata" pane
  • also show the following fields in the "Metadata" pane: publisher, publisher location, page numbers, year, issue, series name, volume, title of the volume.

firefox_screenshot_2018-07-19t18-44-20 909z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - confirmed For issues where a core developer has confirmed a bug exists. Release Blocker Any issue which needs to be addressed before another version of Tripal can be released. Tripal 3 Any issue or pull requuest focused on Tripal 3
Projects
None yet
Development

No branches or pull requests

3 participants