Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 95 php8 catching mismatched parameter names #96

Merged

Conversation

dsenalik
Copy link

Issue #95

This is a single-line fix to make the passed parameter name match the expected name for
function run_BLAST_tripal_job($program, $query, $database, $output_filestub, $options, $job_id = NULL)

Copy link
Member

@laceysanderson laceysanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-) Thanks @dsenalik!

@laceysanderson laceysanderson merged commit f68cf02 into tripal:7.x-1.x Feb 14, 2023
@dsenalik dsenalik deleted the 95-tv3-php8-mismatched-parameter-names branch February 14, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants